Allow using editor as file browser #32
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: robert-hh <[email protected]>
When opening a dir the dir is listed. When viewing a dir listing and positioning the cursor over a file name and pressing Ctrl-O, the file name is used as the default value for the filename prompt.
robert-hh
reviewed
Oct 10, 2025
| key = self.handle_edit_keys(key, char) | ||
| if key == KEY_QUIT: | ||
| if self.hash != self.hash_buffer(): | ||
| if self.hash != self.hash_buffer() and not self.is_dir: |
Owner
There was a problem hiding this comment.
Directory listings were intentionally included into the change check. I do not think that this is a major problem.
robert-hh
reviewed
Oct 10, 2025
| os.chdir(fname) | ||
| if fname in (".", "..", "") or (os.stat(fname)[0] & 0x4000): ## Dir | ||
| os.chdir(fname or ".") | ||
| self.work_dir = os.getcwd() # let the os module do the normalization |
Owner
There was a problem hiding this comment.
An empty file name is meant to open an edit window without a file name, not a directory listing.
robert-hh
reviewed
Oct 10, 2025
| elif key == KEY_GET: | ||
| f = slot[index].line_edit("Open file: ", "", Editor.file_char) | ||
| dfn = slot[index].content[slot[index].cur_line].strip() if slot[index].is_dir else "" | ||
| f = slot[index].line_edit("Open file: ", dfn, Editor.file_char) |
Owner
There was a problem hiding this comment.
To take the file name at the cursor as default name seems intuitive. ATM, you can use CTRL-V in the file name field to copy the text under the cursor. The same thing applies for find.
Owner
|
Thank you for the PR. I have to think about it. I hope that you noticed, that only pye_core has to be edited. Once you run strip.sh, the other files will be created. |
robert-hh
force-pushed
the
master
branch
2 times, most recently
from
a10f174 to
b72717f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening a dir, the dir is listed.
When viewing a dir listing and positioning the cursor over a file name and pressing Ctrl-O,
the file name is used as the default value for the filename prompt.